[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20070919194813.GT32520@schatzie.adilger.int>
Date: Wed, 19 Sep 2007 13:48:13 -0600
From: Andreas Dilger <adilger@...sterfs.com>
To: Mingming Cao <cmm@...ibm.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
Dave Kleikamp <shaggy@...ux.vnet.ibm.com>,
Christoph Hellwig <hch@...radead.org>,
Badari Pulavarty <pbadari@...ibm.com>,
Christoph Lameter <clameter@....com>,
linux-fsdevel <linux-fsdevel@...r.kernel.org>,
ext4 development <linux-ext4@...r.kernel.org>,
lkml <linux-kernel@...r.kernel.org>,
"Stephen C. Tweedie" <sct@...hat.com>
Subject: Re: [PATCH] JBD slab cleanups
On Sep 19, 2007 12:15 -0700, Mingming Cao wrote:
> @@ -96,8 +96,7 @@ static int start_this_handle(journal_t *
>
> alloc_transaction:
> if (!journal->j_running_transaction) {
> - new_transaction = kmalloc(sizeof(*new_transaction),
> - GFP_NOFS|__GFP_NOFAIL);
> + new_transaction = kmalloc(sizeof(*new_transaction), GFP_NOFS);
This should probably be a __GFP_NOFAIL if we are trying to start a new
handle in truncate, as there is no way to propagate an error to the caller.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists