linux-kernel - Re: [PATCH 02/24] rearrange may

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1190314076.26982.151.camel@localhost>
Date:	Thu, 20 Sep 2007 11:47:56 -0700
From:	Dave Hansen <haveblue@...ibm.com>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	akpm@...l.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/24] rearrange may_open() to be r/o friendly

On Wed, 2007-09-19 at 18:27 +0100, Christoph Hellwig wrote:
> >  int permission(struct inode *inode, int mask, struct nameidata *nd)
> >  {
> >  	int retval, submask;
> > +	struct vfsmount *mnt = NULL;
> > +
> > +	if (nd)
> > +		mnt = nd->mnt;
> >  
> >  	if (mask & MAY_WRITE) {
> >  		umode_t mode = inode->i_mode;
> > @@ -251,7 +255,7 @@ int permission(struct inode *inode, int 
> >  		 * MAY_EXEC on regular files is denied if the fs is mounted
> >  		 * with the "noexec" flag.
> >  		 */
> > -		if (nd && nd->mnt && (nd->mnt->mnt_flags & MNT_NOEXEC))
> > +		if (mnt && (mnt->mnt_flags & MNT_NOEXEC))
> 
> Why is this entirely unrelated cleanup in this patch?
> 
> Except for that it looks fine.

You're right.  In this context, it looks completely unrelated.  I'll
separate it into another patch.

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/