linux-kernel - Re: [PATCH] [32/45] x86_64: hide cond_syscall behind __KERNEL_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070922093017.GB27827@infradead.org>
Date:	Sat, 22 Sep 2007 10:30:17 +0100
From:	Christoph Hellwig <hch@...radead.org>
To:	Andi Kleen <ak@...e.de>
Cc:	vapier@...too.org, patches@...-64.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [32/45] x86_64: hide cond_syscall behind __KERNEL__

On Fri, Sep 21, 2007 at 10:45:14PM +0200, Andi Kleen wrote:
> From: Mike Frysinger <vapier@...too.org>
> 
> This brings x86_64 into line with all other architectures by only defining
> cond_syscall() when __KERNEL__ is defined.
> 
> Signed-off-by: Mike Frysinger <vapier@...too.org>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> Signed-off-by: Andi Kleen <ak@...e.de>

> Index: linux/include/asm-x86_64/unistd.h
> ===================================================================
> --- linux.orig/include/asm-x86_64/unistd.h
> +++ linux/include/asm-x86_64/unistd.h
> @@ -676,6 +676,7 @@ asmlinkage long sys_rt_sigaction(int sig
>  #endif	/* __KERNEL__ */

This is the previous __KERNEL__ block.

>  #endif	/* __NO_STUBS */

And this  one shouldn't extent iver the declarations of sys_iopl
and sys_rt_sigactions I think.  If it should be there at all.

So please make this file at least semi-clean while you're at it instead
of much worse.

The __KERNEL__ block should also be extended over the various __ARCH_WANT_
definitions because they're not for userspace at all.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/