linux-kernel - Re: [PATCH] [20/45] x86_64: Use 8 byte stack alignment when possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200710010007.59574.ak@suse.de>
Date:	Mon, 1 Oct 2007 00:07:59 +0200
From:	Andi Kleen <ak@...e.de>
To:	Jakub Jelinek <jakub@...hat.com>
Cc:	patches@...-64.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [20/45] x86_64: Use 8 byte stack alignment when possible

On Friday 21 September 2007 23:19:35 Jakub Jelinek wrote:
> On Fri, Sep 21, 2007 at 10:45:02PM +0200, Andi Kleen wrote:
> > 
> > Kernel doesn't use SSE2, so it doesn't need 16 byte alignment. Also
> > the stack can be already unaligned so letting the compiler align
> > is useless. This may make some stack frames smaller.
> 
> Shouldn't sources that are compiled into the VDSO or VSYSCALL pages
> revert this to the default?

I see not reason. vdso/vsyscall don't contain any SSE code and also don't 
do any callbacks to other user code. Except for signals and signals 
already align the stack by themselves.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/