linux-kernel - Re: [PATCH] [35/50] i386: Do cpuid_device_create() in CPU_UP_PREPARE instead of CPU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1190533952.4035.142.camel@chaos>
Date:	Sun, 23 Sep 2007 09:52:32 +0200
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Akinobu Mita <akinobu.mita@...il.com>
Cc:	Andi Kleen <ak@...e.de>, hpa@...or.com, ego@...ibm.com,
	oleg@...sign.ru, patches@...-64.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [35/50] i386: Do cpuid_device_create() in
	CPU_UP_PREPARE instead of CPU_ONLINE.

On Sun, 2007-09-23 at 10:52 +0900, Akinobu Mita wrote:
> > >  arch/i386/kernel/cpuid.c |   32 +++++++++++++++++++-------------
> > >  1 file changed, 19 insertions(+), 13 deletions(-)
> > >
> > > Index: linux/arch/i386/kernel/cpuid.c
> > > ===================================================================
> > > --- linux.orig/arch/i386/kernel/cpuid.c
> > > +++ linux/arch/i386/kernel/cpuid.c
> > > @@ -136,15 +136,18 @@ static const struct file_operations cpui
> > >       .open = cpuid_open,
> > >  };
> > >
> > > -static int __cpuinit cpuid_device_create(int i)
> > > +static int cpuid_device_create(int cpu)
> >
> >         __cpuinit please
> >
> 
> Yes. This eliminates earlier patch in this series.
> ([22/50] i386: Misc cpuinit annotation)

No, it's even worse:

#22 is applied before #35. 
#35 is reverting the __cpuinit anotation of #22 with its modificiations
of cpuid_device_create()

	tglx


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/