lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 24 Sep 2007 09:23:29 +0100 From: "Jan Beulich" <jbeulich@...ell.com> To: "Andi Kleen" <ak@...e.de> Cc: <linux-kernel@...r.kernel.org>, <patches@...-64.org> Subject: Re: [patches] [PATCH] [13/50] x86: Fix and reenable CLFLUSH support inchange_page_attr() >@@ -162,7 +198,7 @@ __change_page_attr(unsigned long address > /* on x86-64 the direct mapping set at boot is not using 4k pages */ > BUG_ON(PageReserved(kpte_page)); > >- save_page(kpte_page); >+ save_page(kpte_page, 0); > if (page_private(kpte_page) == 0) > revert_page(address, ref_prot); > return 0; What is the point of continuing to launder kpte_page here? Page table pages never get their caching attributes changed, nor would their direct mapping ever change. (Same for i386, obviously.) Jan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists