| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <46F79221.76E4.0078.0@novell.com> Date: Mon, 24 Sep 2007 09:32:01 +0100 From: "Jan Beulich" <jbeulich@...ell.com> To: "Andi Kleen" <ak@...e.de> Cc: <linux-kernel@...r.kernel.org>, <patches@...-64.org> Subject: Re: [patches] [PATCH] [15/50] x86_64: Return EINVAL for unknown addressin change_page_attr This should be accompanied by addr2 = __START_KERNEL_map + __pa(address); /* Make sure the kernel mappings stay executable */ prot2 = pte_pgprot(pte_mkexec(pfn_pte(0, prot))); - err = __change_page_attr(addr2, pfn, prot2, + (void)__change_page_attr(addr2, pfn, prot2, kref_prot(addr2)); } } as otherwise it is non-obvious why there's no check of err (which so far really was missing). The reason this must be tolerated here is free_init_pages()/ free_initmem() removing the translation for the affected kernel image pages altogether. Jan >>> Andi Kleen <ak@...e.de> 22.09.07 00:32 >>> Matches what i386 does and makes more sense. Signed-off-by: Andi Kleen <ak@...e.de> --- arch/x86_64/mm/pageattr.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Index: linux/arch/x86_64/mm/pageattr.c =================================================================== --- linux.orig/arch/x86_64/mm/pageattr.c +++ linux/arch/x86_64/mm/pageattr.c @@ -151,7 +151,9 @@ __change_page_attr(unsigned long address pgprot_t ref_prot2; kpte = lookup_address(address); - if (!kpte) return 0; + if (!kpte) + return -EINVAL; + kpte_page = virt_to_page(((unsigned long)kpte) & PAGE_MASK); BUG_ON(PageCompound(kpte_page)); BUG_ON(PageLRU(kpte_page)); _______________________________________________ patches mailing list patches@...-64.org https://www.x86-64.org/mailman/listinfo/patches - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists