[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20070928083037.GA18295@elte.hu>
Date: Fri, 28 Sep 2007 10:30:37 +0200
From: Ingo Molnar <mingo@...e.hu>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: Thomas Gleixner <tglx@...utronix.de>, roel <12o3l@...cali.nl>,
lkml <linux-kernel@...r.kernel.org>,
Andy Whitcroft <apw@...dowen.org>,
Randy Dunlap <rdunlap@...otime.net>
Subject: Re: [PATCH] spin_lock_unlocked cleanups
* Andrew Morton <akpm@...ux-foundation.org> wrote:
> On Fri, 28 Sep 2007 10:17:30 +0200 Thomas Gleixner <tglx@...utronix.de> wrote:
>
> > can we please add this to checkpatch.pl ?
> >
> > > -spinlock_t bpci_lock = SPIN_LOCK_UNLOCKED;
> > > +DEFINE_SPINLOCK(bpci_lock);
>
> That check is already in checkpatch. Problem is that hardly anyone
> runs the thing.
i automatically run it for every patch i submit or push out via git.
> I think we're ready to wire checkpatch up to a email robot which
> monitors the mailing lists and sends people nastygrams. I bet that'll
> be popular ;)
heh ;-) It could be automated for patches that are sent out with a
Signed-off-by [or a Reviewed-by] line. If you send a SoB patch that is
broken, prepare to get a nastygram. (Initially i'd suggest the nastygram
to Cc: to a different email list, not lkml.)
Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists