linux-kernel - Re: [PATCH 6/6] Xilinxfb: add of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fa686aa40710010946s55e3cf19w1e91a4e5c48b3dd6@mail.gmail.com>
Date:	Mon, 1 Oct 2007 10:46:38 -0600
From:	"Grant Likely" <grant.likely@...retlab.ca>
To:	"Akinobu Mita" <akinobu.mita@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	linux-fbdev-devel@...ts.sourceforge.net, akonovalov@...mvista.com,
	linuxppc@...abs.org, adaplas@...il.com
Subject: Re: [PATCH 6/6] Xilinxfb: add of_platform bus binding

On 10/1/07, Akinobu Mita <akinobu.mita@...il.com> wrote:
> 2007/10/2, Grant Likely <grant.likely@...retlab.ca>:
>
> >  static int __init
> >  xilinxfb_init(void)
> >  {
> > -       /*
> > -        * No kernel boot options used,
> > -        * so we just need to register the driver
> > -        */
> > +       int rc;
> > +       rc = xilinxfb_of_register();
> > +       if (rc)
> > +               return rc;
> > +
> >         return platform_driver_register(&xilinxfb_platform_driver);
>
> Is it better to add error handling for platform_driver_register()?

Right, good catch.  I'll fix that

Thanks!
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@...retlab.ca
(403) 399-0195
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/