[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20071001173930.GA7718@mami.zabbo.net>
Date: Mon, 1 Oct 2007 10:39:30 -0700
From: Zach Brown <zab@...bo.net>
To: David Howells <dhowells@...hat.com>
Cc: hch@...radead.org, viro@....linux.org.uk, torvalds@...l.org,
akpm@...l.org, linux-kernel@...r.kernel.org,
linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read_inode()
If you're soliciting opinions, I think I tend to prefer the feel of the
code paths after the changes. I don't know the benefits of the change
are worth the risk in unmaintained file systems, though.
> + return ERR_PTR(PTR_ERR(inode));
This caught my eye. Surely we can do better :). It seems to happen a
few times in the patches, the instance in this patch was the first that
I noticed.
- z
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists