linux-kernel - Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071001180601.GA9417@infradead.org>
Date:	Mon, 1 Oct 2007 19:06:02 +0100
From:	Christoph Hellwig <hch@...radead.org>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Zach Brown <zab@...bo.net>, David Howells <dhowells@...hat.com>,
	hch@...radead.org, viro@....linux.org.uk,
	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read_inode()

On Mon, Oct 01, 2007 at 10:44:59AM -0700, Linus Torvalds wrote:
> > If you're soliciting opinions, I think I tend to prefer the feel of the
> > code paths after the changes.  I don't know the benefits of the change
> > are worth the risk in unmaintained file systems, though.
> > 
> > > +		return ERR_PTR(PTR_ERR(inode));
> > 
> > This caught my eye.  Surely we can do better :).  It seems to happen a
> > few times in the patches, the instance in this patch was the first that
> > I noticed.
> 
> Yeah. The above obviously *should* be the same as
> 
> 	return inode;
> 
> apart from a few casts. But if the casts matter, there's something else 
> wrong.

befs_lookup, which the above gem is from, returns a dentry *.

And given either

	return (dentry *)inode;

or
	return ERR_PTR(PTR_ERR(inode));

I tend to prefer the latter.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/