linux-kernel - Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.0.999.0710011117570.3579@woody.linux-foundation.org>
Date:	Mon, 1 Oct 2007 11:19:57 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Christoph Hellwig <hch@...radead.org>
cc:	Zach Brown <zab@...bo.net>, David Howells <dhowells@...hat.com>,
	viro@....linux.org.uk, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and
 read_inode()



On Mon, 1 Oct 2007, Christoph Hellwig wrote:
> 
> befs_lookup, which the above gem is from, returns a dentry *.

Ahh, ok. Then it actually makes sense. Although I'd prefer it if people 
planned on writing code like that more along the lines of

	error = PTR_ERR(inode);
	if (IS_ERR(inode)
		return ERR_PTR(error);

because let's face it, the compiler can turn this into nice code, and 
humans can read it much better even if it's got an "unnecessary" extra 
variable etc..

			Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/