linux-kernel - Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <963DCFBD-9E68-488E-BD2C-D8B751E65BDF@zabbo.net>
Date:	Mon, 1 Oct 2007 11:18:21 -0700
From:	Zach Brown <zab@...bo.net>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	David Howells <dhowells@...hat.com>, viro@....linux.org.uk,
	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read_inode()


> 	return ERR_PTR(PTR_ERR(inode));
>
> I tend to prefer the latter.

It seems like a pretty noisy way to get a (void *) cast :/.  Maybe a  
function that has the cast but makes sure it's only used for IS_ERR()  
pointers?

/* haha, continuing the fine tradition of terrible names in this  
api..  */
static inline void *PTR_PTR(void *err_ptr) {
	BUG_ON(!IS_ERR(err_ptr) || !err_ptr);
	return err_ptr;
}

Meh.

- z
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/