[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20071002100610.GA25647@atrey.karlin.mff.cuni.cz>
Date: Tue, 2 Oct 2007 12:06:10 +0200
From: Jan Kara <jack@...e.cz>
To: David Howells <dhowells@...hat.com>
Cc: hch@...radead.org, viro@....linux.org.uk, torvalds@...l.org,
akpm@...l.org, linux-kernel@...r.kernel.org,
linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 11/30] IGET: Stop EXT2 from using iget() and read_inode()
> diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c
> index 0079b2c..d8fb795 100644
> --- a/fs/ext2/inode.c
> +++ b/fs/ext2/inode.c
...
> +
> + raw_inode = ext2_get_inode(inode->i_sb, ino, &bh);
> if (IS_ERR(raw_inode))
> goto bad_inode;
Hmm, why don't you use the return value from raw_inode? It can be
either -EIO or -EINVAL if 'ino' was invalid...
Otherwise the patch looks fine.
Honza
--
Jan Kara <jack@...e.cz>
SuSE CR Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists