linux-kernel - Re: [PATCH 12/30] IGET: Stop EXT3 from using iget() and read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <24599.1191331019@redhat.com>
Date:	Tue, 02 Oct 2007 14:16:59 +0100
From:	David Howells <dhowells@...hat.com>
To:	Jan Kara <jack@...e.cz>
Cc:	dhowells@...hat.com, hch@...radead.org, viro@....linux.org.uk,
	torvalds@...l.org, akpm@...l.org, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 12/30] IGET: Stop EXT3 from using iget() and read_inode()

Jan Kara <jack@...e.cz> wrote:

>   But if you 'goto out' in some branches, we loose the ext3_warning()
> which we probably don't want.

Ugh.  Okay, I need to rework the changes to that function.

> >  			return ERR_PTR(-EACCES);
>   Wouldn't here -EIO be more appropriate?

I would have thought so, but -EACCES was what it returned before I touched it.
OTOH, it's calling ext3_error(), so EIO ought to be the right thing to do.
I'll alter it and see if anyone complains.

>   Why don't we use PTR_ERR() always? Is there some reason not to return
> -EIO?

I do wonder why it used to return EINVAL rather than EIO.  It's understandable
if the magic number doesn't match, but if it appears to be an otherwise
corrupt filesystem, then yes, I guess it should return EIO.  I'll change it.

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/