[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20071003010455.GD26752@sgi.com>
Date: Tue, 2 Oct 2007 18:04:55 -0700
From: akepner@....com
To: David Miller <davem@...emloft.net>
Cc: grundler@...isc-linux.org, jbarnes@...tuousgeek.org, jes@....com,
randy.dunlap@...cle.com, rdreier@...co.com,
James.Bottomley@...eleye.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/4] allow drivers to flush in-flight DMA v2
On Fri, Sep 28, 2007 at 03:43:39PM -0700, David Miller wrote:
> ....
> My only beef with this patch set is that it seems
> a bit much to create a totally new function name every
> time we want to set some kind of new attribute on some
> DMA object. Why not add a "dma_set_flags()" or similar
> that can be used later on to set other kinds of aspects
> we'd like to change?
>
> You can make the arguments "u32 flags" and "int dir".
> Actually you should probably use the dma direction
> enumaration instead of 'int'.
OK, this will be in the next version along with the
coding style changes you mentioned.
--
Arthur
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists