linux-kernel - Re: [PATCH 0/4] allow drivers to flush in-flight DMA v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200710031010.54518.jbarnes@virtuousgeek.org>
Date:	Wed, 3 Oct 2007 10:10:53 -0700
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	akepner@....com
Cc:	David Miller <davem@...emloft.net>, grundler@...isc-linux.org,
	jes@....com, randy.dunlap@...cle.com, rdreier@...co.com,
	James.Bottomley@...eleye.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/4] allow drivers to flush in-flight DMA v2

On Tuesday, October 2, 2007 6:04 pm akepner@....com wrote:
> On Fri, Sep 28, 2007 at 03:43:39PM -0700, David Miller wrote:
> > ....
> > My only beef with this patch set is that it seems
> > a bit much to create a totally new function name every
> > time we want to set some kind of new attribute on some
> > DMA object.  Why not add a "dma_set_flags()" or similar
> > that can be used later on to set other kinds of aspects
> > we'd like to change?
> >
> > You can make the arguments "u32 flags" and "int dir".
> > Actually you should probably use the dma direction
> > enumaration instead of 'int'.
>
> OK, this will be in the next version along with the
> coding style changes you mentioned.

I can't find it now, but IIRC Dave, you vehemently opposed adding a 
flags argument awhile back (~2000), so SGI has been reluctant to push 
it again. :)

Glad you're finally coming around, I think a flags argument makes sense, 
as long as we're careful about adding new ones.

Jesse
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/