linux-kernel - Re: [PATCH] GEODE: decouple sleep/resume from powerdown/powerup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071005131530.GC7397@ucw.cz>
Date:	Fri, 5 Oct 2007 13:15:31 +0000
From:	Pavel Machek <pavel@....cz>
To:	Bernardo Innocenti <bernie@...ewiz.org>
Cc:	Jordan Crouse <jordan.crouse@....com>,
	Andres Solomon <dilinger@...ued.net>,
	OLPC Development <devel@...top.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] GEODE: decouple sleep/resume from powerdown/powerup

Hi!

> This patch merges the fb_powerup and fb_powerdown hooks in a single
> operation fb_power with an additional "state" parameter ranging
> from 0 (running) to 3 (poweroff).

No, please don't. Having int with 0/3 being valid specifying what to
do is evil.

enum is less evil, but what's wrong about having 3 functions?

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/