linux-kernel - Re: [PATCH] GEODE: decouple sleep/resume from powerdown/powerup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 05 Oct 2007 14:38:24 -0400
From:	Bernardo Innocenti <bernie@...ewiz.org>
To:	Pavel Machek <pavel@....cz>
CC:	Jordan Crouse <jordan.crouse@....com>,
	Andres Solomon <dilinger@...ued.net>,
	OLPC Development <devel@...top.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] GEODE: decouple sleep/resume from powerdown/powerup

On 10/05/2007 09:15 AM, Pavel Machek wrote:

>> This patch merges the fb_powerup and fb_powerdown hooks in a single
>> operation fb_power with an additional "state" parameter ranging
>> from 0 (running) to 3 (poweroff).
> 
> No, please don't. Having int with 0/3 being valid specifying what to
> do is evil.
> 
> enum is less evil, but what's wrong about having 3 functions?

Later on, the patch was reworked by Jordan Crouse to use
the fb_blank hook instead, which already has enough states.

So the fb_powerup/fb_powerdown hooks, which were not yet
upstream anyway, died off in the process.

-- 
 \___/
 |___|  Bernardo Innocenti - http://www.codewiz.org/
  \___\ One Laptop Per Child - http://www.laptop.org/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/