lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <200710070144.28075.arnd@arndb.de> Date: Sun, 7 Oct 2007 01:44:26 +0200 From: Arnd Bergmann <arnd@...db.de> To: Christoph Hellwig <hch@...radead.org>, Jens Axboe <jens.axboe@...cle.com>, linux-kernel@...r.kernel.org, davem@...emloft.net, hch@....de, Al Viro <viro@....linux.org.uk> Subject: Re: [patch 1/9] compat_ioctl: move common block ioctls to compat_blkdev_ioctl On Saturday 06 October 2007, Christoph Hellwig wrote: > > +static int compat_put_u64(unsigned long arg, u64 val) > > +{ > > + return put_user(val, (compat_u64 __user *)compat_ptr(arg)); > > +} > > These should probably be in compat.h Hmm, I'm not sure. They are modeled after the put_{short,int,uint,...} functions that only exist in block/ioctl.c and I put them in so I could use almost identical code in the native and compat path. If we find these generally useful, I guess we could have both versions of each of these functions in global headers, e.g. in linux/uaccess.h and linux/compat.h, but right now I would recommend using plain put_user in all compat code except for block ioctl. Arnd <>< - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists