linux-kernel - Re: [patch 8/9] compat_ioctl: call disk->fops->compat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071007095348.GQ8181@ftp.linux.org.uk>
Date:	Sun, 7 Oct 2007 10:53:48 +0100
From:	Al Viro <viro@....linux.org.uk>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Jens Axboe <jens.axboe@...cle.com>, linux-kernel@...r.kernel.org,
	davem@...emloft.net, hch@....de
Subject: Re: [patch 8/9] compat_ioctl: call disk->fops->compat_ioctl without BKL

On Sat, Oct 06, 2007 at 08:19:10PM +0200, Arnd Bergmann wrote:
> Normally, all compat_ioctl operations are called without the BKL, the
> block device operations are an exception to this rule.
> 
> Make this work the same as the other handlers.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> 
> ---
> It would be good to find out whether it has been using the BKL
> on purpose or by accident, before this patch gets applied.

Leave it alone, for now - I'm rebasing my series on top of your 1--7
and it will both makes ->ioctl() and ->compat_ioctl() called unlocked
and switches ->compat_ioctl() to passing bdev instead of struct file
(->unlocked_ioctl() simply dies).
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/