[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20071008100456.dbe826d0.akpm@linux-foundation.org>
Date: Mon, 8 Oct 2007 10:04:56 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: "Yan Zheng" <yanzheng@...n.com>
Cc: linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-mm@...ck.org
Subject: Re: [PATCH]fix VM_CAN_NONLINEAR check in sys_remap_file_pages
On Mon, 8 Oct 2007 19:45:08 +0800 "Yan Zheng" <yanzheng@...n.com> wrote:
> Hi all
>
> The test for VM_CAN_NONLINEAR always fails
>
> Signed-off-by: Yan Zheng<yanzheng@...n.com>
> ----
> diff -ur linux-2.6.23-rc9/mm/fremap.c linux/mm/fremap.c
> --- linux-2.6.23-rc9/mm/fremap.c 2007-10-07 15:03:33.000000000 +0800
> +++ linux/mm/fremap.c 2007-10-08 19:33:44.000000000 +0800
> @@ -160,7 +160,7 @@
> if (vma->vm_private_data && !(vma->vm_flags & VM_NONLINEAR))
> goto out;
>
> - if (!vma->vm_flags & VM_CAN_NONLINEAR)
> + if (!(vma->vm_flags & VM_CAN_NONLINEAR))
> goto out;
>
> if (end <= start || start < vma->vm_start || end > vma->vm_end)
Lovely. From this we can deduce that nobody has run remap_file_pages() since
2.6.23-rc1 and that nobody (including the developer who made that change) ran it
while that change was in -mm.
I'm surprise that LTP doesn't have any remap_file_pages() tests.
Have you runtime tested this change?
Thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists