[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20071008115236.GB2460@hacking>
Date: Mon, 8 Oct 2007 19:52:36 +0800
From: WANG Cong <xiyou.wangcong@...il.com>
To: Yan Zheng <yanzheng@...n.com>
Cc: linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
akpm@...ux-foundation.org
Subject: Re: [PATCH]fix VM_CAN_NONLINEAR check in sys_remap_file_pages
On Mon, Oct 08, 2007 at 07:45:08PM +0800, Yan Zheng wrote:
>Hi all
>
>The test for VM_CAN_NONLINEAR always fails
>
>Signed-off-by: Yan Zheng<yanzheng@...n.com>
>----
>diff -ur linux-2.6.23-rc9/mm/fremap.c linux/mm/fremap.c
>--- linux-2.6.23-rc9/mm/fremap.c 2007-10-07 15:03:33.000000000 +0800
>+++ linux/mm/fremap.c 2007-10-08 19:33:44.000000000 +0800
>@@ -160,7 +160,7 @@
> if (vma->vm_private_data && !(vma->vm_flags & VM_NONLINEAR))
> goto out;
>
>- if (!vma->vm_flags & VM_CAN_NONLINEAR)
>+ if (!(vma->vm_flags & VM_CAN_NONLINEAR))
Good catch!
! operator has higher priority than & operator.
Acked by me. ;-)
> goto out;
>
> if (end <= start || start < vma->vm_start || end > vma->vm_end)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists