| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <64bb37e0710111051w40409d61w91a4ec155abab41a@mail.gmail.com> Date: Thu, 11 Oct 2007 19:51:11 +0200 From: "Torsten Kaiser" <just.for.lkml@...glemail.com> To: "Tejun Heo" <htejun@...il.com> Cc: "Jens Axboe" <jens.axboe@...cle.com>, "Jeff Garzik" <jeff@...zik.org>, linux-kernel@...r.kernel.org, akpm@...ux-foundation.org Subject: Re: sata_sil24 broken since 2.6.23-rc4-mm1 On 10/11/07, Tejun Heo <htejun@...il.com> wrote: > Torsten Kaiser wrote: > >>> That missing +1 would explain, why the SGE_TRM never gets set. > >> Thanks a lot for tracking this down. Does changing the above code fix > >> your problem? > > > > I did not try it. > > I'm not an libata expert and while this change looks suspicios, I > > can't be 100% sure if that change was intended. > > And I did not want to experiment this deep in the code and risk > > corrupting the hole drive. > > I don't think you would risk too much by changing that bit of code. > Please try it. The debug output now shows that SGE_TRM is getting set. I will try to reproduce the error tomorrow morning, and report if I'm still seeing it. Reporting that I'm no longer see it is sadly not a good indicator, as it also seems to depend on other factors like memory layout and/or code alignment. Torsten - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists