linux-kernel - Re: [PATCH] FAT: Fix printk format strings.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87odf5h86j.fsf@duaron.myhome.or.jp>
Date:	Fri, 12 Oct 2007 02:28:52 +0900
From:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:	7eggert@....de
Cc:	Vegard Nossum <vegard.nossum@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] FAT: Fix printk format strings.

Bodo Eggert <7eggert@....de> writes:

> Vegard Nossum <vegard.nossum@...il.com> wrote:
>
>> This makes sure printk format strings contain no more than a single
>> line.
>
>>  printk(KERN_WARNING
>> -                            "FAT: Did not find valid FSINFO signature.\n"
>> +                            "FAT: Did not find valid FSINFO signature.\n");
>> +                     printk(KERN_WARNING
>>  "     Found signature1 0x%08x signature2 0x%08x"
>>  " (sector = %lu)\n",
>
> What about something like
> "Fat32: Invalid FSINFO signatures 0x%08x, 0x%08x; expected 0x%08x, 0x%08\n" ?
> or
> "Fat32: Invalid FSINFO signatures 0x%08x, 0x%08x\n" ?

Looks good to me. I'll modify a patch, and apply it.

Thanks.
-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/