linux-kernel - Re: [PATCH] init: Fix printk format strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 11 Oct 2007 21:15:35 +0200
From:	"Vegard Nossum" <vegard.nossum@...il.com>
To:	"Johannes Weiner" <hannes-kernel@...urebad.de>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] init: Fix printk format strings

On 10/11/07, Johannes Weiner <hannes-kernel@...urebad.de> wrote:
> On Thu, Oct 11, 2007 at 08:17:02AM +0200, Vegard Nossum wrote:
> > This makes sure printk format strings are string literals containing no
> > more than a single line.
>
> Perhaps you should write _why_ one-line printk()s are even needed, with
> profound reasons instead of constantly talking about mysterious later changes
> that you will propose any time soon.

In short, the reason for disallowing multiple lines per call is that
printk() will be less complex, while not really changing the
complexity of the callers (a change in the code, yes, but the changes
are trivial, and, actually, not that many).

I think I see now, though, that my changes will not gain support if I
do not lift this restriction.

You can find my current "mysterious later changes" as patches, with
descriptions, at this address: http://folk.uio.no/vegardno/xprintf/

Thanks for the tip, though. I am quite new to the kernel business, so
bear with me :)

Kind regards,
Vegard Nossum
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/