[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.58.0710120809490.8900@gandalf.stny.rr.com>
Date: Fri, 12 Oct 2007 08:10:50 -0400 (EDT)
From: Steven Rostedt <rostedt@...dmis.org>
To: Gregory Haskins <ghaskins@...ell.com>
cc: Peter Zijlstra <peterz@...radead.org>,
linux-rt-users <linux-rt-users@...r.kernel.org>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/7] RT: Only consider online CPUs when pushing rt tasks
--
On Thu, 11 Oct 2007, Gregory Haskins wrote:
> task->cpus_allowed can have bit positions that are set for CPUs that are
> not currently online. So we optimze our search by ANDing against the online
> set.
>
> Signed-off-by: Gregory Haskins <ghaskins@...ell.com>
> ---
>
> kernel/sched.c | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/sched.c b/kernel/sched.c
> index 24b38b4..0ca3905 100644
> --- a/kernel/sched.c
> +++ b/kernel/sched.c
> @@ -1510,10 +1510,14 @@ static int push_rt_task(struct rq *this_rq)
>
> /* Only try this algorithm three times */
> for (tries = 0; tries < 3; tries++) {
> + cpumask_t mask;
> +
> + cpus_and(mask, cpu_online_map, next_task->cpus_allowed);
> +
Gag! I definitely sent you an old patch. I fixed this a while ago :-(
-- Steve
> /*
> * Scan each rq for the lowest prio.
> */
> - for_each_cpu_mask(cpu, next_task->cpus_allowed) {
> + for_each_cpu_mask(cpu, mask) {
> struct rq *rq = &per_cpu(runqueues, cpu);
>
> if (cpu == smp_processor_id())
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists