linux-kernel - Re: [patch] scsi: fix crash in gdth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4713B4E7.2050001@panasas.com>
Date:	Mon, 15 Oct 2007 20:43:51 +0200
From:	Boaz Harrosh <bharrosh@...asas.com>
To:	Jeff Garzik <jeff@...zik.org>
CC:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org,
	James Bottomley <James.Bottomley@...elEye.com>
Subject: Re: [patch] scsi: fix crash in gdth_timeout()

On Mon, Oct 15 2007 at 19:57 +0200, Jeff Garzik <jeff@...zik.org> wrote:
> Linus Torvalds wrote:
>> On Mon, 15 Oct 2007, Ingo Molnar wrote:
>>> A further problem is probably that the GDTH timer is not stopped by a
>>> failed GDTH probe?
>> Indeed. Maybe this is a better fix?
>>
>> That driver is pretty messy, and this should have been found ealier. 
>> James? Boaz?
> 
> FWIW, the gdth driver was "super-messy".  With this latest SCSI pull, 
> that severity has been successfully downgraded to "messy" :)
> 
> IMO some easy-to-fix breakage was inevitable with such a large volume of 
> fundamental changes.
> 
> Honestly, the driver is probably rarely run by people that lack the 
> hardware, I bet...
> 
> 	Jeff

It was all "flight by instruments only". I called for HW testers and none 
came forward. All these changes, apart from "successful downgrade to messy"
where also needed in order to push important changes to scsi.

But a little bird said that QEMU might simulate this HW. SO I guess it is
QEMU time for me.

Boaz
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/