linux-kernel - Re: [patch] scsi: fix crash in gdth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071015192456.GA9046@elte.hu>
Date:	Mon, 15 Oct 2007 21:24:56 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org, Boaz Harrosh <bharrosh@...asas.com>,
	James Bottomley <James.Bottomley@...elEye.com>
Subject: Re: [patch] scsi: fix crash in gdth_timeout()


* Linus Torvalds <torvalds@...ux-foundation.org> wrote:

> On Mon, 15 Oct 2007, Ingo Molnar wrote:
> > 
> > A further problem is probably that the GDTH timer is not stopped by a
> > failed GDTH probe?
> 
> Indeed. Maybe this is a better fix?
> 
> That driver is pretty messy, and this should have been found ealier. 
> James? Boaz?

> @@ -5213,6 +5213,10 @@ static int __init gdth_init(void)
>  #endif /* CONFIG_PCI */
>  
>  	TRACE2(("gdth_detect() %d controller detected\n", gdth_ctr_count));
> +
> +	if (list_empty(&gdth_instances))
> +		return -ENODEV;

indeed - with this patch instead of the one i did the CONFIG_SCSI_GDTH=y 
bzImage boots up fine too, and no crash:

 Calling initcall 0x80a417e0: gdth_init+0x0/0xb20()
 GDT-HA: Storage RAID Controller Driver. Version: 3.05
 GDT-HA: Found 0 PCI Storage RAID Controllers
 initcall 0x80a417e0: gdth_init+0x0/0xb20() returned -19.
 initcall 0x80a417e0 ran for 5 msecs: gdth_init+0x0/0xb20()

Tested-by: Ingo Molnar <mingo@...e.hu>

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/