linux-kernel - Re: WARNING: at net/core/dev.c:2161 net_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071015.152126.85410587.davem@davemloft.net>
Date:	Mon, 15 Oct 2007 15:21:26 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mingo@...e.hu
Cc:	linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
	shemminger@...ux-foundation.org, jgarzik@...ox.com
Subject: Re: WARNING: at net/core/dev.c:2161 net_rx_action()

From: Ingo Molnar <mingo@...e.hu>
Date: Tue, 16 Oct 2007 00:07:20 +0200

> looking at the dev.c code - can napi_struct->weight be zero 
> legitimately? If yes then the 0 gets passed to the driver and the driver 
> would return 1 - violating the assertion.

I touched upon this in another reply.

For forcedeth it should never be zero, it gets set in
netif_napi_add() to RX_WORK_PER_LOOP which is unconditionally
defined to 64.

Afterwards napi->weight should never be modified and that is
what is passed into n->poll().

Perhaps some memory scribble is causing it to be zero'd.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/