[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20071015152245.12d29f8b.akpm@linux-foundation.org>
Date: Mon, 15 Oct 2007 15:22:45 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: "Mike Frysinger" <vapier.adi@...il.com>
Cc: bryan.wu@...log.com, dmitry.torokhov@...il.com,
linux-input@...ey.karlin.mff.cuni.cz,
linux-joystick@...ey.karlin.mff.cuni.cz,
linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] Blackfin serial driver: this driver enable SPORTs
on Blackfin emulate UART
On Mon, 15 Oct 2007 18:03:35 -0400
"Mike Frysinger" <vapier.adi@...il.com> wrote:
> > It is not a good idea to create files in /proc which have spaces in their
> > names. Yes, userspace _should_ be able to cope with that in all cases, but
> > all software sucks, even including userspace ;)
> >
> > I'd suggest that we be defensive here, and avoid using spaces in filenames.
>
> i'm not sure i follow ... these are the names given to request_irq()
> which means this is what shows up in /proc/interrupts ... does this
> function also create an actual file somewhere in /proc that i am not
> aware of ?
err, umm, yeah. But the same argument applies: it is imprudent to have
space-containing records in /proc/interrupts.
However it seems that we've already done that in several places so I guess
any /proc/interrupts-parsing programs are already coping with it OK.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists