linux-kernel - Re: [patch] forcedeth: fix the NAPI poll function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4713EC8A.5010607@garzik.org>
Date:	Mon, 15 Oct 2007 18:41:14 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Jeff Garzik <jgarzik@...ox.com>
CC:	Ingo Molnar <mingo@...e.hu>, David Miller <davem@...emloft.net>,
	linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
	shemminger@...ux-foundation.org
Subject: Re: [patch] forcedeth: fix the NAPI poll function

Jeff Garzik wrote:
>> --- linux.orig/drivers/net/forcedeth.c
>> +++ linux/drivers/net/forcedeth.c
>> @@ -2274,7 +2274,7 @@ static int nv_rx_process(struct net_devi
>>  
>>      while((np->get_rx.orig != np->put_rx.orig) &&
>>            !((flags = le32_to_cpu(np->get_rx.orig->flaglen)) & 
>> NV_RX_AVAIL) &&
>> -        (rx_processed_cnt++ < limit)) {
>> +        (++rx_processed_cnt < limit)) {
>>  
>>          dprintk(KERN_DEBUG "%s: nv_rx_process: flags 0x%x.\n",
>>                      dev->name, flags);
>> @@ -2412,7 +2412,7 @@ static int nv_rx_process_optimized(struc
>>  
>>      while((np->get_rx.ex != np->put_rx.ex) &&
>>            !((flags = le32_to_cpu(np->get_rx.ex->flaglen)) & 
>> NV_RX2_AVAIL) &&
>> -          (rx_processed_cnt++ < limit)) {
>> +          (++rx_processed_cnt < limit)) {


Though it wasn't clear, that's an ACK

I'll push the patch if nobody else beats me to it.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/