lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20071016054236.GA27906@elte.hu>
Date:	Tue, 16 Oct 2007 07:42:36 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Jeff Garzik <jgarzik@...ox.com>
Cc:	David Miller <davem@...emloft.net>, linux-kernel@...r.kernel.org,
	torvalds@...ux-foundation.org, shemminger@...ux-foundation.org
Subject: Re: [patch] forcedeth: fix the NAPI poll function


* Jeff Garzik <jgarzik@...ox.com> wrote:

> Two comments:
> 
> 1) we have a vague definition of "RX work processed."  Due to error 
> conditions and goto's in that function, rx_processed_cnt may or may 
> not equal the number of packets actually processed.
> 
> 2) man I dislike these inline C statement combinations (ranting at 
> original code style, not you).  I would much rather waste a few extra 
> lines of source code and make the conditions obvious:
> 
> 	while (... && (rx_processed_cnt < limit)) {
> 		rx_processed_cnt++;
> 
> 		...
> 	}
> 
> or even
> 
> 	while (1) {
> 		...
> 		if (rx_processed_cnt == limit)
> 			break;
> 		rx_processed_cnt++;
> 	}
> 
> The compiler certainly doesn't care, and IMO it prevents bugs.

agreed. Do you have an uptodate patch/git-URI for the forcedeth rewrite 
you did? I can throw it into the testbed.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ