linux-kernel - Re: PCIe Hotplug: NFG unless I boot with card already inserted.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071016140116.cb30483c.kristen.c.accardi@intel.com>
Date:	Tue, 16 Oct 2007 14:01:16 -0700
From:	Kristen Carlson Accardi <kristen.c.accardi@...el.com>
To:	Mark Lord <lkml@....ca>
Cc:	pcihpd-discuss@...ts.sourceforge.net,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: PCIe Hotplug:  NFG unless I boot with card already inserted.

On Tue, 16 Oct 2007 16:39:25 -0400
Mark Lord <lkml@....ca> wrote:

> Kristen Carlson Accardi wrote:
> >...
> > I tried to reproduce this on a Lenovo T61, which does have proper firmware
> > support for _OSC, and also has been validated, and the driver which is 
> > in 2.6.23-git8 seems to work fine, even across suspend resume.  I suspect
> > that your system just doesn't support pcie hotplug properly.
> 
> No, the hardware seems to work perfectly.
> 
> We just have a software issue.  We *know* it's only software
> because rmmod+modprobe fixes things, without any hardware intervention.

This reinitializes the controller, which is probably why things work
better for you (which does of course touch hardware...).

> 
> I believe the code is leaning too heavily on the BIOS for stuff,
> and like lots of other parts of the kernel we'll need an alternate
> strategy for when things aren't "perfect".

the pitfall for forcing pciehp when the BIOS hasn't provided OSC is that
you don't know for sure that you really have gained control of hot plug
operation properly.  You can obviously try it, using the provide forcing
option as you have done, but the behavior is not predictable.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/