linux-kernel - Re: [PATCH] swiotlb: fix map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20071017080534.GB5043@kernel.dk>
Date:	Wed, 17 Oct 2007 10:05:34 +0200
From:	Jens Axboe <jens.axboe@...cle.com>
To:	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
Cc:	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
	tomof@....org
Subject: Re: [PATCH] swiotlb: fix map_sg failure handling

On Wed, Oct 17 2007, FUJITA Tomonori wrote:
> sg list elements might not be continuous.
> 
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
> ---
>  lib/swiotlb.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lib/swiotlb.c b/lib/swiotlb.c
> index c419ecf..752fd95 100644
> --- a/lib/swiotlb.c
> +++ b/lib/swiotlb.c
> @@ -696,7 +696,7 @@ swiotlb_map_sg(struct device *hwdev, struct scatterlist *sgl, int nelems,
>  				/* Don't panic here, we expect map_sg users
>  				   to do proper error handling. */
>  				swiotlb_full(hwdev, sg->length, dir, 0);
> -				swiotlb_unmap_sg(hwdev, sg - i, i, dir);
> +				swiotlb_unmap_sg(hwdev, sgl, i, dir);
>  				sgl[0].dma_length = 0;
>  				return 0;
>  			}

Auch indeed, no math on sg entries! Applied.

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/