linux-kernel - Re: [bug] block subsystem related crash with latest -git

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.0.999.0710171119250.26902@woody.linux-foundation.org>
Date:	Wed, 17 Oct 2007 11:22:39 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Jens Axboe <jens.axboe@...cle.com>
cc:	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [bug] block subsystem related crash with latest -git



On Wed, 17 Oct 2007, Linus Torvalds wrote:
> 
> So I think your change to use "sg_next()" only when you actually need a 
> next pointer is the correct one after all.

That still leaves the initialization issue. The link pointers need to all 
be initialized at SG allocation time (and not just the last one for the 
case where it's a linked entry).

And if you initialize them at allocation time, does an allocation ever get 
re-used without being free'd in between (if it does, you do indeed need to 
initialize the non-link pointers each time - but I don't see it being the 
case, so ..)

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/