linux-kernel - Re: mmc_spi stopped working

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071017215217.177cdb14@poseidon.drzeus.cx>
Date:	Wed, 17 Oct 2007 21:52:17 +0200
From:	Pierre Ossman <drzeus-list@...eus.cx>
To:	David Brownell <david-b@...bell.net>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: mmc_spi stopped working

On Wed, 17 Oct 2007 12:37:13 -0700
David Brownell <david-b@...bell.net> wrote:

> 
> That issue is 49dce689ad4ef0fd1f970ef762168e4bd46f69a3, the
> classdev-elimination patch from Tony Jones.  It broke the
> "does this bus have more than one device" test by relocating
> the relevant sysfs nodes.
> 
> Quick workaround for that one is to disable the fault return
> after that test.
> 

Annoying. Feel free to ping me when you've pushed fixes to Linus.

> When enumerating MMC cards using SPI, don't support the "just probe"
> mechanism since it doesn't always work.  Instead, always wait for the
> reset to complete before issuing the next request.
> 
> This is a regression ... this SanDisk MMC card used to enumerate with
> no trouble, despite this particular spec violation.
> 
> Signed-off-by: David Brownell <dbrownell@...rs.sourceforge.net>
> 

I think I'll have to NAK this as I believe it breaks MMC 4.2. I'll check
and get back to you.

Rgds
-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  PulseAudio, core developer          http://pulseaudio.org
  rdesktop, core developer          http://www.rdesktop.org
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/