linux-kernel - hwmon/f75375s.c: buggy if()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071017195439.GD3778@stusta.de>
Date:	Wed, 17 Oct 2007 21:54:39 +0200
From:	Adrian Bunk <bunk@...nel.org>
To:	Riku Voipio <riku.voipio@....fi>,
	"Mark M. Hoffman" <mhoffman@...htlink.com>
Cc:	lm-sensors@...sensors.org, linux-kernel@...r.kernel.org
Subject: hwmon/f75375s.c: buggy if()

drivers/hwmon/f75375s.c contains the following code:

<--  snip  -->

...
static ssize_t set_pwm_mode(struct device *dev, struct device_attribute *attr,
                const char *buf, size_t count)
{
...
        if (val != 0 || val != 1 || data->kind == f75373)
                return -EINVAL;
...

<--  snip  -->

I'm not sure what exactly was intended, but it was for sure not intended 
to always return -EINVAL...

Spotted by the Coverity checker.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/