linux-kernel - Re: [PATCH 1/3] dma: add dma_flags_set/get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071016202728.81450e25.akpm@linux-foundation.org>
Date:	Tue, 16 Oct 2007 20:27:28 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	akepner@....com
Cc:	Tony Luck <tony.luck@...el.com>,
	Grant Grundler <grundler@...isc-linux.org>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Jes Sorensen <jes@....com>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Roland Dreier <rdreier@...co.com>,
	James Bottomley <James.Bottomley@...eleye.com>,
	David Miller <davem@...emloft.net>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] dma: add dma_flags_set/get_*() interfaces

On Tue, 16 Oct 2007 18:41:28 -0700 akepner@....com wrote:

> +#define DMA_BARRIER_ATTR	0x1
> +#ifndef ARCH_USES_DMA_ATTRS
> +static inline int dma_flags_set_attr(u32 attr, enum dma_data_direction dir) 
> +{
> +	return dir;
> +}

This function takes an `enum dma_data_direction' as its second arg, but your
ia64 implementation takes an 'int'.

> +static inline int dma_flags_get_dir(int flags)
> +{
> +	return flags;
> +}
> +
> +static inline int dma_flags_get_attr(int flags)
> +{
> +	return 0;
> +}


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/