linux-kernel

Open Source and information security mailing list archives

Message-Id: <200710191051.51686.bjorn.helgaas@hp.com>
Date:	Fri, 19 Oct 2007 10:51:51 -0600
From:	Bjorn Helgaas <bjorn.helgaas@...com>
To:	linux-pcmcia@...ts.infradead.org
Cc:	linux-kernel@...r.kernel.org,
	Dominik Brodowski <linux@...inikbrodowski.net>
Subject: PCMCIA driver resource allocation

Question 1: Does the linux-pcmcia list still exist?  It's in MAINTAINERS:

  PCMCIA SUBSYSTEM
  P:      Linux PCMCIA Team
  L:      linux-pcmcia@...ts.infradead.org
  L:      http://lists.infradead.org/mailman/listinfo/linux-pcmcia
  T:      git kernel.org:/pub/scm/linux/kernel/git/brodo/pcmcia-2.6.git
  S:      Maintained

but the archive: http://lists.infradead.org/mailman/listinfo/linux-pcmcia
seems dead.

Question 2: Documentation/pcmcia/driver-changes.txt says drivers should
now claim their own resources:

  * Resource management. (as of 2.6.8)
     Although the PCMCIA subsystem will allocate resources for cards,
     it no longer marks these resources busy. This means that driver
     authors are now responsible for claiming your resources as per
     other drivers in Linux.

But I don't see any drivers that do that.  It looks like there should
be a bunch of changes like the one below.  Is there a reason these
changes didn't happen, other than just lack of interest?

Bjorn


Index: work3/drivers/net/wireless/orinoco.h
===================================================================

--- work3.orig/drivers/net/wireless/orinoco.h	2007-10-18 10:56:34.000000000 -0600
+++ work3/drivers/net/wireless/orinoco.h	2007-10-18 13:22:06.000000000 -0600
@@ -57,6 +57,7 @@
 	struct iw_statistics wstats;
 
 	/* Hardware control variables */
+	struct resource *io_resource;
 	hermes_t hw;
 	u16 txfid;
 
Index: work3/drivers/net/wireless/orinoco_cs.c
===================================================================
--- work3.orig/drivers/net/wireless/orinoco_cs.c	2007-10-18 10:56:34.000000000 -0600
+++ work3/drivers/net/wireless/orinoco_cs.c	2007-10-18 13:22:44.000000000 -0600
@@ -296,6 +296,10 @@
 	/* We initialize the hermes structure before completing PCMCIA
 	 * configuration just in case the interrupt handler gets
 	 * called. */
+	priv->io_resource = request_region(link->io.BasePort1,
+					   link->io.NumPorts1, DRIVER_NAME);
+	if (!priv->io_resource)
+		goto cs_failed;
 	mem = ioport_map(link->io.BasePort1, link->io.NumPorts1);
 	if (!mem)
 		goto cs_failed;
@@ -366,6 +370,10 @@
 	pcmcia_disable_device(link);
 	if (priv->hw.iobase)
 		ioport_unmap(priv->hw.iobase);
+	if (priv->io_resource) {
+		release_resource(priv->io_resource);
+		priv->io_resource = NULL;
+	}
 }				/* orinoco_cs_release */
 
 static int orinoco_cs_suspend(struct pcmcia_device *link)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives