[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20071019141118.91846dee.akpm@linux-foundation.org>
Date: Fri, 19 Oct 2007 14:11:18 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: dougthompson@...ssion.com
Cc: dougthompson@...ssion.com, alan@...rguk.ukuu.org.uk,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/8] drivers-edac-i3000 replace macros with functions
On Fri, 19 Oct 2007 13:18:23 -0600
dougthompson@...ssion.com wrote:
> +static inline unsigned long deap_pfn(u8 edeap, u32 deap)
> +{
> + deap >>= PAGE_SHIFT;
> + deap |= (edeap & 1) << (32 - PAGE_SHIFT);
> + return deap;
> +}
> +
> +static inline unsigned long deap_offset(u32 deap)
> +{
> + return deap & ~(I3000_DEAP_GRAIN - 1) & ~PAGE_MASK;
> +}
> +
The types here look a bit confused. Implicit conversions of
u32s into unsigned longs.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists