linux-kernel - Re: [PATCH 6/8] drivers-edac-i3000 replace macros with functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <282333.62461.qm@web50104.mail.re2.yahoo.com>
Date:	Fri, 19 Oct 2007 16:58:29 -0700 (PDT)
From:	Doug Thompson <norsk5@...oo.com>
To:	Andrew Morton <akpm@...ux-foundation.org>, juhlenko@...mai.com
Cc:	dougthompson@...ssion.com, alan@...rguk.ukuu.org.uk,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/8] drivers-edac-i3000 replace macros with functions

Jason,

Can you provide some information on this?

doug t


--- Andrew Morton <akpm@...ux-foundation.org> wrote:

> On Fri, 19 Oct 2007 13:18:23 -0600
> dougthompson@...ssion.com wrote:
> 
> > +static inline unsigned long deap_pfn(u8 edeap, u32 deap)
> > +{
> > +	deap >>= PAGE_SHIFT;
> > +	deap |= (edeap & 1) << (32 - PAGE_SHIFT);
> > +	return deap;
> > +}
> > +
> > +static inline unsigned long deap_offset(u32 deap)
> > +{
> > +	return deap & ~(I3000_DEAP_GRAIN - 1) & ~PAGE_MASK;
> > +}
> > +
> 
> The types here look a bit confused.  Implicit conversions of
> u32s into unsigned longs.
> 


W1DUG
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/