[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <200710211957.11928.nickpiggin@yahoo.com.au>
Date: Sun, 21 Oct 2007 19:57:11 +1000
From: Nick Piggin <nickpiggin@...oo.com.au>
To: David Woodhouse <dwmw2@...radead.org>
Cc: Erez Zadok <ezk@...sunysb.edu>, jffs-dev@...s.com,
linux-kernel@...r.kernel.org, linux-mtd@...ts.infradead.org
Subject: Re: BUG at mm/filemap.c:1749 (2.6.24, jffs2, unionfs)
On Sunday 21 October 2007 18:55, David Woodhouse wrote:
> On Fri, 2007-10-19 at 17:16 +1000, Nick Piggin wrote:
> > if (writtenlen) {
> > - if (inode->i_size < (pg->index << PAGE_CACHE_SHIFT) +
> > start + writtenlen) { - inode->i_size = (pg->index
> > << PAGE_CACHE_SHIFT) + start + writtenlen; + if
> > (inode->i_size < pos + start + writtenlen) {
> > + inode->i_size = pos + start + writtenlen;
>
> This part seems wrong. Shouldn't it just be pos + writtenlen -- which is
> basically what it was already: pos==(pg->index<<PAGE_CACHE_SHIFT)+start
Yeah you're right, thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists