linux-kernel - Re: BUG at mm/filemap.c:1749 (2.6.24, jffs2, unionfs)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1192956944.2672.6.camel@shinybook.infradead.org>
Date:	Sun, 21 Oct 2007 09:55:44 +0100
From:	David Woodhouse <dwmw2@...radead.org>
To:	Nick Piggin <nickpiggin@...oo.com.au>
Cc:	Erez Zadok <ezk@...sunysb.edu>, jffs-dev@...s.com,
	linux-kernel@...r.kernel.org, linux-mtd@...ts.infradead.org
Subject: Re: BUG at mm/filemap.c:1749 (2.6.24, jffs2, unionfs)

On Fri, 2007-10-19 at 17:16 +1000, Nick Piggin wrote:
> 
>         if (writtenlen) {
> -               if (inode->i_size < (pg->index << PAGE_CACHE_SHIFT) + start + writtenlen) {
> -                       inode->i_size = (pg->index << PAGE_CACHE_SHIFT) + start + writtenlen;
> +               if (inode->i_size < pos + start + writtenlen) {
> +                       inode->i_size = pos + start + writtenlen;

This part seems wrong. Shouldn't it just be pos + writtenlen -- which is
basically what it was already: pos==(pg->index<<PAGE_CACHE_SHIFT)+start

-- 
dwmw2

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/