linux-kernel - Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 23 Oct 2007 01:19:27 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
Cc:	Al Viro <viro@....linux.org.uk>,
	WANG Cong <xiyou.wangcong@...il.com>,
	Sam Ravnborg <sam@...nborg.org>, Nix <nix@...eri.org.uk>,
	Jeff Dike <jdike@...toit.com>,
	Paolo Giarrusso <p.giarrusso@...il.com>,
	user-mode-linux-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, Rob Landley <rob@...dley.net>
Subject: Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final.


* Jeremy Fitzhardinge <jeremy@...p.org> wrote:

> Ingo Molnar wrote:
> > we should kill it there too.
> >
> > the only place where we should _please_ keep those annotations are for 
> > functions that get called from assembly code. This makes life immensely 
> > easier for -pg (CONFIG_FUNCTION_TRACING) kernels.
> 
> Should we re-add them for the function pointers in asm-x86/paravirt.h?

yes, yes, yes. :-) It was a nightmare to sort it out in -rt (and still 
is). It's also good documentation - it pinpoints functions that are 
called from assembly.

> Andi argued we should remove them since x86 is unconditionally regparm 
> now anyway - and they're pretty ugly syntactically.

Sure, it doesnt make things prettier, but i didnt see any particular 
ugliness.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/