linux-kernel - Re: [PATCH 09/10] Change table chaining layout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <p738x5t4nbn.fsf@bingen.suse.de>
Date:	Tue, 23 Oct 2007 21:56:28 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Jens Axboe <jens.axboe@...cle.com>
Cc:	Boaz Harrosh <bharrosh@...asas.com>, torvalds@...ux-foundation.org,
	linux-kernel@...r.kernel.org, mingo@...e.hu
Subject: Re: [PATCH 09/10] Change table chaining layout

Jens Axboe <jens.axboe@...cle.com> writes:

>> You might want to put a BUG_ON(page & 0x3); Make sure
>> you're not loosing information. (The m68k problem)
>
> That's a really good idea, thanks Boaz! I'll add that.

It would be even better if you replaced all the magic numbers with defines
or better accessors.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/