[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20071023202017.GI14671@kernel.dk>
Date: Tue, 23 Oct 2007 22:20:17 +0200
From: Jens Axboe <jens.axboe@...cle.com>
To: Andi Kleen <andi@...stfloor.org>
Cc: Boaz Harrosh <bharrosh@...asas.com>, torvalds@...ux-foundation.org,
linux-kernel@...r.kernel.org, mingo@...e.hu
Subject: Re: [PATCH 09/10] Change table chaining layout
On Tue, Oct 23 2007, Andi Kleen wrote:
> Jens Axboe <jens.axboe@...cle.com> writes:
>
> >> You might want to put a BUG_ON(page & 0x3); Make sure
> >> you're not loosing information. (The m68k problem)
> >
> > That's a really good idea, thanks Boaz! I'll add that.
>
> It would be even better if you replaced all the magic numbers with defines
> or better accessors.
All? There are two numbers, and all are confined to scatterlist.h
privately. Except the one in blk_rq_map_sg(), which was done on purpose
since I don't want to export that knowledge to others. So we definitely
don't want accessors, I can name the two bit values but don't see much
point in doing it.
--
Jens Axboe
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists