linux-kernel - Re: [RFC] what the hell is going on with /proc/self?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071023202039.GK17536@waste.org>
Date:	Tue, 23 Oct 2007 15:20:39 -0500
From:	Matt Mackall <mpm@...enic.com>
To:	Al Viro <viro@....linux.org.uk>
Cc:	linux-kernel@...r.kernel.org,
	"Eric W. Biederman" <ebiederm@...ssion.com>
Subject: Re: [RFC] what the hell is going on with /proc/self?

On Tue, Oct 23, 2007 at 03:03:36AM +0100, Al Viro wrote:
> 	What is the proc_base_stuff[] nonsense about?  AFAICS, that
> went in with no reason whatsoever in
> commit 801199ce805a2412bbcd9bfe213092ec656013dd
> Author: Eric W. Biederman <ebiederm@...ssion.com>
> Date:   Mon Oct 2 02:18:48 2006 -0700
> 
> 	Rationale is very weak and patch adds considerable complexity
> for no good reason.  Besides, it's obfuscated just for the hell of it:
> 	if (!IS_ERR(result) || PTR_ERR(result) != -ENOENT)
> instead of
> 	if (result != ERR_PTR(-ENOENT))
> etc.
> 
> 	Unless there are _real_ plans that would justify that animal,
> I'm going to get rid of it in the pending patch series (/proc/self
> cleanups, saner dentry retention for non-process parts, etc.).

Seems obvious to cc: Eric.

-- 
Mathematics is the supreme nostalgia of our time.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/