linux-kernel - Re: [HP ProLiant WatchDog driver] hpwdt HP WatchDog Patch <resend>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071023212032.GA26597@infradead.org>
Date:	Tue, 23 Oct 2007 22:20:32 +0100
From:	Christoph Hellwig <hch@...radead.org>
To:	Bjorn Helgaas <bjorn.helgaas@...com>
Cc:	thomas.mingarelli@...com, linux-kernel@...r.kernel.org,
	Wim Van Sebroeck <wim@...ana.be>
Subject: Re: [HP ProLiant WatchDog driver] hpwdt HP WatchDog Patch <resend>

On Tue, Oct 23, 2007 at 02:31:15PM -0600, Bjorn Helgaas wrote:
> The driver assumes only a single instance of the device.  But PCI being
> what it is, it's often possible to have multiple cards, so you might
> want some protection in case you trip over more than one.

Yes.  And even with that protection please move all the global variables
into some per-device structure.  That makes the code a lot more understandable
and future-proof in case multiple devices of this type may appear somewhere.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/