[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20071023212026.GF7793@redhat.com>
Date: Tue, 23 Oct 2007 17:20:26 -0400
From: Dave Jones <davej@...hat.com>
To: Jeff Garzik <jeff@...zik.org>
Cc: "Kok, Auke" <auke-jan.h.kok@...el.com>,
Adam Jackson <ajax@...hat.com>, linux-kernel@...r.kernel.org,
David Miller <davem@...emloft.net>,
netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] Add eeprom_bad_csum_allow module option to e1000.
On Tue, Oct 23, 2007 at 04:40:01PM -0400, Jeff Garzik wrote:
> > In any case, this patch should not be merged. We often send it around to users to
> > debug their issue in case it involves eeproms, but merging it will just conceal
> > the real issue and all of a sudden a flood of people stop reporting *real* issues
> > to us.
>
> Sorry, I disagree. Just as with e100, if there is a clear way the user
> can recover their setup -- and Adam says his was effective -- I don't
> see why we should be denying users the ability to use their own hardware.
Indeed. This is a common enough problem that not including it causes more pain
than its worth. I have two affected boxes myself that I actually thought
the hardware was dead before I tried ajax's patch.
People aren't going to report this as a bug. They aren't going to try out patches,
they're going to do what I did and stick another network card in the box and
go on with life.
Our users deserve better than this.
Dave
--
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists